MINOR: tidy up SocketServerMemoryPoolTest#21873
Open
edoardocomar wants to merge 3 commits intoapache:trunkfrom
Open
MINOR: tidy up SocketServerMemoryPoolTest#21873edoardocomar wants to merge 3 commits intoapache:trunkfrom
edoardocomar wants to merge 3 commits intoapache:trunkfrom
Conversation
edoardocomar
force-pushed
the
ec/KAFKA-20302-test-tidy
branch
from
c49e6f9 to
71d21c7
Compare
* moved to package org.apache.kafka.common * use IntegrationTestUtils and RequestUtils to create messages * made SocketServer MemoryPool accessible for testing
edoardocomar
force-pushed
the
ec/KAFKA-20302-test-tidy
branch
from
71d21c7 to
7f38206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following up comments in #21740
note that the MemoryPoolAvailable metrics is registered in the singleton
default Yammer registry and it is not scoped per listener because there
is one pool per SocketServer, not one per listener. So it is not usable
in this ClusterTest.